Fix potential vulnerable cloned function #8572
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlexPeshkoff should it be merged or were there any reasons to postpone it? |
The only reason not to merge - our code never calls tommath functions in wrong way like negative number of digits. On the other hand - changes are absolutely safe. What do you think - do we need such fix, or may be just switch to fresh tommath version? |
|
For v6, I suppose we may just update our libtom-imported sources. If this needs to be backported, the suggested patch is preferred -- although I doubt this is necessary given that our usage of the library is not affected by this CVE. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Development Team,
I identified a potential integer overflow in clone functions in files in
extern/libtommathsourced from libtom/libtommath. This issue, originally reported in CVE-2023-36328, was resolved in the repository via this commit libtom/libtommath@beba892.This PR applies the corresponding patch to fix the vulnerability in this codebase.
Please review at your convenience. Thank you!